Site changes and upgrade roadmap 2013-2014

OK, my fault then: check postbit_legacy instead of postbit. On the default skin, at least, it seems to use postbit_legacy instead.

 

druid, your wrong it's a clear and float issue. I will help him if he messages me (also will help install the selling mod) - This was not a serious "your wrong" btw:|

 

/a>
</vb:if>
<vb:if condition="$post['userid']">
<hr />
<dl class="userinfo_extra">
<dt>{vb:raw post.crowns}{vb:raw post.champtext}</dd><br />
<vb:if condition="$post['joindate']"><dt>{vb:rawphrase join_date}</dt> <dd>{vb:raw post.joindate}</dd></vb:if>
<vb:if condition="$post['field2']"><dt>{vb:rawphrase location_perm}</dt> <dd>{vb:raw post.field2}</dd></vb:if>
<vb:if condition="$post['age']"><dt>{vb:rawphrase age}</dt> <dd>{vb:raw post.age}</dd></vb:if>
<dt>{vb:rawphrase posts}</dt> <dd>{vb:raw post.posts}</dd>
{vb:raw template_hook.postbit_userinfo_right_after_posts}
</dl>

From what I see it's going to be elsewhere. Adding more breaks does nothing.

 

Assembler, just PM me on AIM. I will have it all fixed in 2 minutes. natalichwolf -- I have already wrote the fix. You're not really adding breaks, you're literally just breaking it.

 

Find <dl class="userinfo_extra"> then the </dl> after the _right_after_posts hook and replace

<dl class="userinfo_extra">
<dt>{vb:raw post.crowns}{vb:raw post.champtext}</dd><br />
<vb:if condition="$post['joindate']"><dt style="clear:both">{vb:rawphrase join_date}</dt> <dd style="float:left">{vb:raw post.joindate}</dd></vb:if>
<vb:if condition="$post['field2']"><dt style="clear:both">{vb:rawphrase location_perm}</dt> <dd style="float:left">{vb:raw post.field2}</dd></vb:if>
<vb:if condition="$post['age']"><dt style="clear:both">{vb:rawphrase age}</dt> <dd style="float:left">{vb:raw post.age}</dd></vb:if>
<dt style="clear:both">{vb:rawphrase posts}</dt> <dd style="float:left">{vb:raw post.posts}</dd>
{vb:raw template_hook.postbit_userinfo_right_after_posts}
</dl>

 

.postbitlegacy dl.userinfo_extra dd { float:left!important}
.postbitlegacy dl.userinfo_extra dt {clear: both!important;}
.postbitlegacy dl.user_rep dt {clear:both!important}
.postbitlegacy dl.user_rep dd {float:left!important}

 

Find <form
Above it put <vb:if condition="($vbulletin->userinfo['posts'] >= 50 && $foruminfo['forumid'] == 8 ) || $foruminfo['forumid'] != 8">

Now find </form>
Under it paste

<vb:else />
<div class="blockhead">Requirements Error!</div>
<div class="blockbody" style="font-weight:bold; font-size:18px;>Error: You do not have enough posts to post in this section.<br /><a href="http://www.assemblergames.com/forums/showthread.php?4888-MARKETPLACE-RULES-as-of-September2013">Read Rules and Requirements for Posting In Sales Section</a></div>
</vb:if>

 

Thanks to leetwolf for the help!

We now have properly aligned text under the avatars, and a marketplace spam filter.

 

So users under 50 posts can't make threads in the marketplace? Well that will relieve some mod work.

 

Thanks to leetwolf

 

That's some fairly ugly boolean logic. How about "($foruminfo['forumid'] !=8 || $vbulletin->userinfo['posts'] >= 50)"?

 

Not quite. If you check the page source you'll see that there is some un-closed dt/dd tags there... in fact there still are. It is true that they are positioned with float/clear, but the problem is caused by some extra unclosed tags.

See here:

This is very unprofessional. You are adding unnecessary inline float/clears, but ignore the malformed HTML.

In fact now we have an extra colon between the avatar and post infos.

What you should do instead is this:

Those changes in the CSS were also unnecessary; the stylesheet is fine, it was the HTML that was malformed.

 

Yeah, you're right, that would work. Oh well It was a first draft, I never optimized it.

 

Being honest, I never noticed unclosed tag, the HTML is a mess to look at. It was to help the site and late. Druid is right, removing that line or fixing the tag will resolve the issue proper. I had told him to remove that extra line, but we never did it (so I noticed it but never realized it was the cause). I honestly have never used the dt and dd tags (never worked with Vbulletin either haha), so it didn't catch my attention like say a div would have. Yeah yeah, should have noticed it...I spent all day working on my own code so....give me a break

And just to be fair, it took you a while to find it! Muahahah!

 

I was asleep, and I first mentioned the unclosed dt/dd lines approx. half a year ago.

Right click on the problematic area, select "inspect element" (may vary depending on browser). In the DOM Explorer, find the nearest unique class identifier, then press ctrl+u to view the source (preferable with notepad++ set to HTML display), and ctrl+f for the class identifier.

Basic debugging for any web dev.

 

If I had noticed it, I would have fixed it. It was an oversight on my part, I usually am good at seeing that stuff.

 

No need to nitpick. He missed it, you caught it, it's fixed. As someone who does web development too, this is an easy thing to miss with a complex DOM.

 

He wants to be right he can be. Thats on him. I know my skill set. Google my name you will see what I do all day.

 

I'm not saying this to be right, I'm just saying, it IS the most basic debugging possible... it doesn't even matter how complex the DOM is because you can immediately pinpoint the area in question from its unique class. You don't even have to look for it, really.

 

Let's stick to agreeing on optimal code. This is a cooperative effort.